Fix visualization of multi-branch info gathering and unexecuted components test #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bence Szépkúti <[email protected]>
This prepares us for the refactor in the next commit. Signed-off-by: Bence Szépkúti <[email protected]>
bensze01
added
enhancement
bensze01
force-pushed
the
dev/bensze01/multi-branch-info
branch
from
552431f to
8935999
Compare
Blue Ocean doesn't display nested parallel stages correctly, so instead refactor get_branch_info and check_every_all_sh_component_will_be_run to handle multiple branches at once. Signed-off-by: Bence Szépkúti <[email protected]>
Blue Ocean does not properly display "single-threaded" steps in any stage that also includes a parallel step. Separate the BranchInfo gathering into its own separate step, so the other checks are displayed properly. Signed-off-by: Bence Szépkúti <[email protected]>
bensze01
force-pushed
the
dev/bensze01/multi-branch-info
branch
from
8935999 to
be28b7d
Compare
bensze01
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blue Ocean doesn't display nested parallel stages correctly, so instead
refactor get_branch_info and check_every_all_sh_component_will_be_run to
handle multiple branches at once.
Also separate the unexecuted components check to its own stage, because Blue Ocean doesn't display any "single threaded" steps that share a stage with a
parallelstepCI runs: